jenkins-bot has submitted this change and it was merged. Change subject: sitelinkview: Improved pagesuggester performance ......................................................................
sitelinkview: Improved pagesuggester performance (requires https://github.com/wmde/ValueView/pull/137) Change-Id: Ibbff182edb7fa30bfc994a7a3e2802fb16d1148c --- M composer.json M lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Tobias Gritschacher: Looks good to me, approved jenkins-bot: Verified diff --git a/composer.json b/composer.json index d6e4e38..a202db7 100644 --- a/composer.json +++ b/composer.json @@ -33,7 +33,7 @@ "data-values/data-types": "~0.4.0", "data-values/serialization": "~1.0", "data-values/javascript": "~0.6.0", - "data-values/value-view": "~0.9.0", + "data-values/value-view": "~0.9.1", "wikibase/data-model": "~2.4", "wikibase/data-model-javascript": "~1.0", diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js index 2a46003..72bf6ba 100644 --- a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js +++ b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinkview.js @@ -251,10 +251,14 @@ dir: dir } ).pagesuggester( pageNameInputOptions ); + var pagesuggester = $pageNameInput.data( 'pagesuggester' ); + $pageNameInput .on( 'pagesuggesterchange.' + this.widgetName, function( event ) { - self.setError(); - self._trigger( 'change' ); + if( !pagesuggester.isSearching() ) { + self.setError(); + self._trigger( 'change' ); + } } ); this.$link.find( '.wikibase-sitelinkview-page' ).empty().append( $pageNameInput ); @@ -270,8 +274,6 @@ .siteselector( { source: self.options.getAllowedSites } ); - - var pagesuggester = $pageNameInput.data( 'pagesuggester' ); // Disable and hide initially and wait for valid site input: pagesuggester.disable(); -- To view, visit https://gerrit.wikimedia.org/r/180128 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbff182edb7fa30bfc994a7a3e2802fb16d1148c Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater <[email protected]> Gerrit-Reviewer: Legoktm <[email protected]> Gerrit-Reviewer: Tobias Gritschacher <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
