jenkins-bot has submitted this change and it was merged.
Change subject: Removed obsolete caseInsensitive option from highlightSubstring
calls
......................................................................
Removed obsolete caseInsensitive option from highlightSubstring calls
caseInsensitive options was remove in ValueView 0.9.0 and replaced by
"caseSensitive"
defaulting to false.
Change-Id: I9d91ed0e59f873d5ce1955a33061eed7a5f230bb
---
M lib/resources/jquery.wikibase-shared/jquery.wikibase.siteselector.js
M lib/resources/jquery.wikibase/jquery.wikibase.pagesuggester.js
2 files changed, 3 insertions(+), 9 deletions(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git
a/lib/resources/jquery.wikibase-shared/jquery.wikibase.siteselector.js
b/lib/resources/jquery.wikibase-shared/jquery.wikibase.siteselector.js
index d9b027e..771962a 100644
--- a/lib/resources/jquery.wikibase-shared/jquery.wikibase.siteselector.js
+++ b/lib/resources/jquery.wikibase-shared/jquery.wikibase.siteselector.js
@@ -230,12 +230,8 @@
* @return {string}
*/
_createItemLabel: function( site, requestTerm ) {
- return util.highlightSubstring( requestTerm,
site.getShortName(), {
- caseInsensitive: true
- } )
- + ' (' + util.highlightSubstring( requestTerm,
site.getId(), {
- caseInsensitive: true
- } ) + ')';
+ return util.highlightSubstring( requestTerm,
site.getShortName() )
+ + ' (' + util.highlightSubstring( requestTerm,
site.getId() ) + ')';
},
/**
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.pagesuggester.js
b/lib/resources/jquery.wikibase/jquery.wikibase.pagesuggester.js
index d501b82..c2d3040 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.pagesuggester.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.pagesuggester.js
@@ -117,9 +117,7 @@
*/
_createMenuItemFromSuggestion: function( suggestion, requestTerm ) {
return new $.ui.ooMenu.Item(
- util.highlightSubstring( requestTerm, suggestion, {
- caseInsensitive: true
- } ),
+ util.highlightSubstring( requestTerm, suggestion ),
suggestion
);
}
--
To view, visit https://gerrit.wikimedia.org/r/180445
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d91ed0e59f873d5ce1955a33061eed7a5f230bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
