jenkins-bot has submitted this change and it was merged.
Change subject: Log Last-Modified header in performance logger
......................................................................
Log Last-Modified header in performance logger
Bug: T78767
Change-Id: If747453b32cbe1db7e307193609af9eaa2bdcc7d
---
M MultimediaViewer.php
M resources/mmv/logging/mmv.logging.PerformanceLogger.js
2 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Gergő Tisza: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MultimediaViewer.php b/MultimediaViewer.php
index e421476..9af5c04 100644
--- a/MultimediaViewer.php
+++ b/MultimediaViewer.php
@@ -1063,7 +1063,7 @@
$wgHooks['EventLoggingRegisterSchemas'][] = function( array &$schemas ) {
$schemas += array(
'MediaViewer' => 10606177,
- 'MultimediaViewerNetworkPerformance' => 10596581,
+ 'MultimediaViewerNetworkPerformance' => 10774577,
'MultimediaViewerDuration' => 10427980,
'MultimediaViewerAttribution' => 9758179,
'MultimediaViewerDimensions' => 10014238,
diff --git a/resources/mmv/logging/mmv.logging.PerformanceLogger.js
b/resources/mmv/logging/mmv.logging.PerformanceLogger.js
index 2ac6e1b..df3fedd 100644
--- a/resources/mmv/logging/mmv.logging.PerformanceLogger.js
+++ b/resources/mmv/logging/mmv.logging.PerformanceLogger.js
@@ -185,7 +185,8 @@
contentLength,
xcache,
xvarnish,
- varnishXCache;
+ varnishXCache,
+ lastModified;
if ( !request ) {
return;
@@ -223,6 +224,11 @@
}
stats.timestamp = new Date( request.getResponseHeader( 'Date' )
).getTime() / 1000;
+
+ lastModified = request.getResponseHeader( 'Last-Modified' );
+ if ( lastModified ) {
+ stats.lastModified = new Date( lastModified ).getTime()
/ 1000;
+ }
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/180433
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If747453b32cbe1db7e307193609af9eaa2bdcc7d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gilles <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
