Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/180775

Change subject: Remove border-box rule from reset.less
......................................................................

Remove border-box rule from reset.less

Having this rule applied generally is potentially hugely problematic
as evidenced by the fact it had to be overriden for CentralNotice. In
the future it could be a blocker to importing a module. If a specific
part of MF requires border-box it should be applied in a targetted
manner.

Currently MobileFrontend makes almost no use of this, I couldn't
see any more than single pixel changes when disabling the style.

Change-Id: I9d85c2fd09613736d51cb75bb6d151b840ebd1dd
---
M less/reset.less
1 file changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/75/180775/1

diff --git a/less/reset.less b/less/reset.less
index fe0affa..d5d8cf0 100644
--- a/less/reset.less
+++ b/less/reset.less
@@ -21,15 +21,9 @@
        font: inherit;
        vertical-align: baseline;
        background: none;
-       .box-sizing(border-box);
 }
 table, caption, tbody, tfoot, thead, tr, th, td {
        font-size: 100%;
-       .box-sizing(border-box);
-}
-// CentralNotice banners use regular box-sizing
-div#centralNotice {
-       .box-sizing(content-box);
 }
 button {
        border: none;

-- 
To view, visit https://gerrit.wikimedia.org/r/180775
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d85c2fd09613736d51cb75bb6d151b840ebd1dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to