Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180901
Change subject: Hygiene: Document PhotoUploaderButton.js
......................................................................
Hygiene: Document PhotoUploaderButton.js
Change-Id: I54c69cbc620d60ccb5590bbd65ec3adc60a83d51
---
M javascripts/modules/uploads/PhotoUploaderButton.js
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/01/180901/1
diff --git a/javascripts/modules/uploads/PhotoUploaderButton.js
b/javascripts/modules/uploads/PhotoUploaderButton.js
index a157792..37a6eb3 100644
--- a/javascripts/modules/uploads/PhotoUploaderButton.js
+++ b/javascripts/modules/uploads/PhotoUploaderButton.js
@@ -10,6 +10,7 @@
/**
* Check whether photo upload is supported
+ * FIXME: Move to Browser.js
* @method
* @ignore
* @returns {Boolean}
@@ -65,8 +66,17 @@
var self = this,
$input = this.$( 'input' );
+ /**
+ * Hacky way to open a preview overlay with a certain
image
+ * FIXME: Ideally the upload-preview URI should feature
a representation of the image
+ * that can be used to create the upload overlay.
+ * @ignore
+ */
function handleFile( file ) {
- // FIXME: this is hacky but it would be hard to
pass a file in a route
+ /*
+ * @event _upload-preview
+ * Emitted when a user has selected a file of
their local machine
+ */
M.emit( '_upload-preview', file );
M.router.navigate( '#/upload-preview/' +
self.options.funnel );
}
--
To view, visit https://gerrit.wikimedia.org/r/180901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54c69cbc620d60ccb5590bbd65ec3adc60a83d51
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
