Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/181056
Change subject: Suggester visibility depend on spinner visibility
......................................................................
Suggester visibility depend on spinner visibility
This fixes the issue of the spinner not becoming visible.
There is an other problem: this._term is empty _after_ I typed the
first character. But I think this patch can be merged independent
from this issue.
Change-Id: I0295ec9d15608089f3686ae9f3c63cea76a1aba9
---
M repo/resources/jquery.wikibase/jquery.wikibase.entitysearch.js
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/56/181056/1
diff --git a/repo/resources/jquery.wikibase/jquery.wikibase.entitysearch.js
b/repo/resources/jquery.wikibase/jquery.wikibase.entitysearch.js
index c18c727..5e55c00 100644
--- a/repo/resources/jquery.wikibase/jquery.wikibase.entitysearch.js
+++ b/repo/resources/jquery.wikibase/jquery.wikibase.entitysearch.js
@@ -103,11 +103,13 @@
* @see jQuery.ui.suggester._updateMenuVisibility
*/
_updateMenuVisibility: function() {
- if( !this._term.length ) {
- this._close();
- } else {
+ if( this._term || ( this.options.suggestionsPlaceholder
+ && this.options.suggestionsPlaceholder.getVisibility() )
+ ) {
this._open();
this.repositionMenu();
+ } else {
+ this._close();
}
},
--
To view, visit https://gerrit.wikimedia.org/r/181056
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0295ec9d15608089f3686ae9f3c63cea76a1aba9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
