jenkins-bot has submitted this change and it was merged.
Change subject: SpecialImport: Don't access $this->getConfig() in the
constructor
......................................................................
SpecialImport: Don't access $this->getConfig() in the constructor
The context is only set later on, so call it in the main
execute() function.
Bug: T73376
Change-Id: I34229877df6a8960756565f7df1d680aa8951cba
---
M includes/specials/SpecialImport.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialImport.php
b/includes/specials/SpecialImport.php
index da2df2d..c6ebaed 100644
--- a/includes/specials/SpecialImport.php
+++ b/includes/specials/SpecialImport.php
@@ -47,7 +47,6 @@
*/
public function __construct() {
parent::__construct( 'Import', 'import' );
- $this->namespace = $this->getConfig()->get(
'ImportTargetNamespace' );
}
/**
@@ -58,6 +57,8 @@
$this->setHeaders();
$this->outputHeader();
+ $this->namespace = $this->getConfig()->get(
'ImportTargetNamespace' );
+
$this->getOutput()->addModules( 'mediawiki.special.import' );
$user = $this->getUser();
--
To view, visit https://gerrit.wikimedia.org/r/179959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34229877df6a8960756565f7df1d680aa8951cba
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: TTO <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits