Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/181100
Change subject: Hygiene: check return types
......................................................................
Hygiene: check return types
Change-Id: Ifdf56f817340d708a8b079d05af10bb992f71dc4
---
M .jscsrc
M javascripts/Page.js
M javascripts/modules/PageList.js
M javascripts/modules/uploads/PhotoApi.js
M javascripts/modules/watchlist/WatchList.js
5 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/00/181100/1
diff --git a/.jscsrc b/.jscsrc
index 0ae6855..7da490c 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -21,6 +21,7 @@
"jsDoc": {
"enforceExistence": true,
"checkReturnTypes": true,
- "checkRedundantReturns": true
+ "checkRedundantReturns": true,
+ "requireReturnTypes": true
}
}
diff --git a/javascripts/Page.js b/javascripts/Page.js
index 720385f..416578c 100644
--- a/javascripts/Page.js
+++ b/javascripts/Page.js
@@ -201,7 +201,7 @@
* FIXME: rename to getSections
*
* @method
- * @return Array
+ * @return {Array}
*/
getSubSections: function () {
return this.sections;
diff --git a/javascripts/modules/PageList.js b/javascripts/modules/PageList.js
index f503187..c26d0b6 100644
--- a/javascripts/modules/PageList.js
+++ b/javascripts/modules/PageList.js
@@ -105,7 +105,7 @@
*
* @method
* @param {Array} ids a list of page ids
- * @return jQuery.deferred
+ * @return {jQuery.deferred}
*/
getPages: function ( ids ) {
return this.api.load( ids );
diff --git a/javascripts/modules/uploads/PhotoApi.js
b/javascripts/modules/uploads/PhotoApi.js
index 2f8bc0f..d9adc0b 100644
--- a/javascripts/modules/uploads/PhotoApi.js
+++ b/javascripts/modules/uploads/PhotoApi.js
@@ -153,7 +153,7 @@
* @param {Object} options
* options.file File A file object obtained from a file
input.
* options.description String Image description.
- * @return jQuery.Deferred On failure callback is passed an
object with
+ * @return {jQuery.Deferred} On failure callback is passed an
object with
* `stage`, `type` and `details` properties. `stage` is either
"upload"
* or "edit" (inserting image in a page). `type` is a string
describing
* the type of error, `details` can be any object (usually a
string
diff --git a/javascripts/modules/watchlist/WatchList.js
b/javascripts/modules/watchlist/WatchList.js
index 3582dfd..2e97895 100644
--- a/javascripts/modules/watchlist/WatchList.js
+++ b/javascripts/modules/watchlist/WatchList.js
@@ -13,7 +13,7 @@
*
* @method
* @param {Array} ids a list of page ids
- * @return jQuery.deferred
+ * @return {jQuery.deferred}
*/
getPages: function ( ids ) {
return this.api.load( ids, true );
--
To view, visit https://gerrit.wikimedia.org/r/181100
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifdf56f817340d708a8b079d05af10bb992f71dc4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
