Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/181098
Change subject: Hygiene: jscs should check return types
......................................................................
Hygiene: jscs should check return types
Fix existing errors
Change-Id: I57319e7c892c8076cb2c4de2e338a7bbdc09a766
---
M .jscsrc
M javascripts/OverlayManager.js
M javascripts/PageApi.js
3 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/98/181098/1
diff --git a/.jscsrc b/.jscsrc
index b005941..46a09a1 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -19,6 +19,7 @@
"node_modules/jscs-jsdoc/lib/rules/*.js"
],
"jsDoc": {
- "enforceExistence": true
+ "enforceExistence": true,
+ "checkReturnTypes": true,
}
}
diff --git a/javascripts/OverlayManager.js b/javascripts/OverlayManager.js
index 8375d9e..7440a28 100644
--- a/javascripts/OverlayManager.js
+++ b/javascripts/OverlayManager.js
@@ -151,7 +151,7 @@
* @private
* @param {String} path Path (hash) to check.
* @param {Object} entry Entry object created in
OverlayManager#add.
- * @return {Object} Match object with factory function's
result. Returns null if no match.
+ * @return {Object|null} Match object with factory function's
result. Returns null if no match.
* or null if no match.
*/
_matchRoute: function ( path, entry ) {
diff --git a/javascripts/PageApi.js b/javascripts/PageApi.js
index cbbd9a1..99229f0 100644
--- a/javascripts/PageApi.js
+++ b/javascripts/PageApi.js
@@ -230,7 +230,7 @@
* @private
* @param {String} title Name of the page to obtain variants
for
* @param {Object} data Data from API
- * @return {Array} List of language variant objects
+ * @return {Array|Boolean} List of language variant objects or
false if no variants exist
*/
_getLanguageVariantsFromApiResponse: function ( title, data ) {
var generalData = data.query.general,
--
To view, visit https://gerrit.wikimedia.org/r/181098
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I57319e7c892c8076cb2c4de2e338a7bbdc09a766
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
