Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/181376
Change subject: Minor updates to VE integration code
......................................................................
Minor updates to VE integration code
* Removed unused styles
* Use surface getter
* Remove CE blur call, has been upstreamed
Change-Id: I18d91e07983b5201b6ea0d62479d1bf9de9e1a9b
---
M javascripts/modules/editor/VisualEditorOverlay.js
M less/modules/editor/VisualEditorOverlay.less
2 files changed, 2 insertions(+), 14 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/76/181376/1
diff --git a/javascripts/modules/editor/VisualEditorOverlay.js
b/javascripts/modules/editor/VisualEditorOverlay.js
index 7d04bc5..515c638 100644
--- a/javascripts/modules/editor/VisualEditorOverlay.js
+++ b/javascripts/modules/editor/VisualEditorOverlay.js
@@ -48,8 +48,6 @@
*/
destroyTarget: function () {
if ( this.target ) {
- // keyboard stays open on iOS when we close the
editor if we don't blur
- this.$( '[contenteditable]' ).blur();
this.target.destroy();
this.target = null;
this.docToSave = null;
@@ -206,10 +204,10 @@
onSurfaceReady: function () {
this.clearSpinner();
this.$( '.surface' ).show();
- this.target.surface.getModel().getDocument().connect(
this, {
+
this.target.getSurface().getModel().getDocument().connect( this, {
transact: 'onTransact'
} );
- this.target.surface.$element.addClass( 'content' );
+ this.target.getSurface().$element.addClass( 'content' );
// we have to do it here because contenteditable
elements still do not
// exist when postRender is executed
diff --git a/less/modules/editor/VisualEditorOverlay.less
b/less/modules/editor/VisualEditorOverlay.less
index 6d78c0f..5c11686 100644
--- a/less/modules/editor/VisualEditorOverlay.less
+++ b/less/modules/editor/VisualEditorOverlay.less
@@ -1,16 +1,6 @@
@import "minerva.variables";
@import "minerva.mixins";
-// These are set as !important since they have to override styles set in
VisualEditor
-// FIXME: Remove protected node once VE is correctly identifying which nodes
are
-// supported in mobile.
-.ve-ce-alienNode-phantom,
-.ve-ce-protectedNode-phantom {
- box-shadow: none !important;
- opacity: 0.5 !important;
- background-color: white !important;
-}
-
.editor-overlay-ve .content {
// VisualEditor doesn't have collapsible-heading class, so we need to
apply
// heading styles to the header tags directly.
--
To view, visit https://gerrit.wikimedia.org/r/181376
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I18d91e07983b5201b6ea0d62479d1bf9de9e1a9b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
