jenkins-bot has submitted this change and it was merged.
Change subject: ULS width according to the number of languages
......................................................................
ULS width according to the number of languages
Bug: T76196
Change-Id: I369f879828315ca45c9fe9cf709ba6c81ae30ba0
---
M modules/source/ext.cx.source.selector.js
1 file changed, 26 insertions(+), 1 deletion(-)
Approvals:
Jsahleen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/source/ext.cx.source.selector.js
b/modules/source/ext.cx.source.selector.js
index 150fef6..1803392 100644
--- a/modules/source/ext.cx.source.selector.js
+++ b/modules/source/ext.cx.source.selector.js
@@ -51,6 +51,23 @@
}
/**
+ * Return the appropriate menuWidth parameter for a given language count
+ * @param {number} languagesCount Number of languages
+ * return {string} wide, medium or narrow
+ */
+ function getUlsMenuWidth( languagesCount ) {
+ if ( languagesCount <= 12 ) {
+ return 'narrow';
+ }
+
+ if ( languagesCount <= 100 ) {
+ return 'medium';
+ }
+
+ return 'wide';
+ }
+
+ /**
* Initialize the plugin.
*/
CXSourceSelector.prototype.init = function () {
@@ -248,6 +265,7 @@
// Create a new target ULS
this.$targetLanguage.uls( {
languages: getAutonyms( this.targetLanguages ),
+ menuWidth: getUlsMenuWidth( this.targetLanguages.length
),
onSelect: function ( language ) {
cxSourceSelector.targetLanguageChangeHandler(
language );
},
@@ -595,13 +613,19 @@
* Show the CXSourceSelector
*/
CXSourceSelector.prototype.show = function () {
- var $container = this.options.container;
+ var sourceUls, targetUls,
+ $container = this.options.container;
if ( $container && $container instanceof jQuery ) {
this.showAsEmbedded( $container );
} else {
this.showAsDialog();
}
+
+ sourceUls = this.$sourceLanguage.data( 'uls' );
+ sourceUls.left = this.$sourceLanguage.offset().left;
+ targetUls = this.$targetLanguage.data( 'uls' );
+ targetUls.left = this.$targetLanguage.offset().left;
};
/**
@@ -807,6 +831,7 @@
this.$sourceLanguage.uls( {
languages: getAutonyms( this.sourceLanguages ),
+ menuWidth: getUlsMenuWidth( this.sourceLanguages.length
),
onSelect: function ( language ) {
cxSourceSelector.sourceLanguageChangeHandler(
language );
},
--
To view, visit https://gerrit.wikimedia.org/r/177536
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I369f879828315ca45c9fe9cf709ba6c81ae30ba0
Gerrit-PatchSet: 11
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Jsahleen <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Pginer <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
