Deskana has uploaded a new change for review.
https://gerrit.wikimedia.org/r/181429
Change subject: Don't transmit search results events in TitleSearchFragment
funnel.
......................................................................
Don't transmit search results events in TitleSearchFragment funnel.
The search funnel is meant to track user-perceived performance of search, and
since the autoswitching means the user never perceives a zero result event for
a title search, it doesn't make sense to log it.
Change-Id: Ie974ef89eb3ff15a608ee3303b1c8574a78f136f
---
M wikipedia/src/main/java/org/wikipedia/search/TitleSearchFragment.java
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/29/181429/1
diff --git
a/wikipedia/src/main/java/org/wikipedia/search/TitleSearchFragment.java
b/wikipedia/src/main/java/org/wikipedia/search/TitleSearchFragment.java
index 988211d..9192d97 100644
--- a/wikipedia/src/main/java/org/wikipedia/search/TitleSearchFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/search/TitleSearchFragment.java
@@ -294,7 +294,12 @@
if (!isAdded()) {
return;
}
- searchFragment.getFunnel().searchResults(false,
result.size(), (int)(System.currentTimeMillis() - startMillis));
+ /*
+ Don't transmit searchResults events in this fragment
right now, since the
+ autoswitching means the user never perceives zero
results within the context
+ of this fragment.
+ searchFragment.getFunnel().searchResults(false,
result.size(), (int)(System.currentTimeMillis() - startMillis));
+ */
((PageActivity)getActivity()).updateProgressBar(false,
true, 0);
searchNetworkError.setVisibility(View.GONE);
displayResults(result);
--
To view, visit https://gerrit.wikimedia.org/r/181429
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie974ef89eb3ff15a608ee3303b1c8574a78f136f
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
