Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/181699
Change subject: Hygiene: Rename misleading onSave name
......................................................................
Hygiene: Rename misleading onSave name
It is actually on the completion of a save and might be confused
with the _save method
Change-Id: I9c89a733f92f23daf7b35608c9dd345ec11898d2
---
M javascripts/modules/editor/EditorOverlay.js
M javascripts/modules/editor/EditorOverlayBase.js
M javascripts/modules/editor/VisualEditorOverlay.js
3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/99/181699/1
diff --git a/javascripts/modules/editor/EditorOverlay.js
b/javascripts/modules/editor/EditorOverlay.js
index 4418ed5..44fba9a 100644
--- a/javascripts/modules/editor/EditorOverlay.js
+++ b/javascripts/modules/editor/EditorOverlay.js
@@ -337,7 +337,7 @@
return;
}
- self.onSave();
+ self.onSaveComplete();
} )
.fail( function ( data, code, response ) {
var msg,
diff --git a/javascripts/modules/editor/EditorOverlayBase.js
b/javascripts/modules/editor/EditorOverlayBase.js
index 588ccf1..ac8bb6a 100644
--- a/javascripts/modules/editor/EditorOverlayBase.js
+++ b/javascripts/modules/editor/EditorOverlayBase.js
@@ -143,7 +143,7 @@
* messages, and setting mobile edit cookie.
* @method
*/
- onSave: function () {
+ onSaveComplete: function () {
var msg,
title = this.options.title,
self = this;
diff --git a/javascripts/modules/editor/VisualEditorOverlay.js
b/javascripts/modules/editor/VisualEditorOverlay.js
index c86289b..a3cd6b5 100644
--- a/javascripts/modules/editor/VisualEditorOverlay.js
+++ b/javascripts/modules/editor/VisualEditorOverlay.js
@@ -70,7 +70,7 @@
this.target.activating = true;
this.target.load();
this.target.connect( this, {
- save: 'onSave',
+ save: 'onSaveComplete',
saveAsyncBegin: 'showSpinner',
saveAsyncComplete: 'clearSpinner',
saveErrorEmpty: 'onSaveError',
@@ -192,8 +192,8 @@
} );
},
/** @inheritdoc **/
- onSave: function () {
- EditorOverlayBase.prototype.onSave.apply( this,
arguments );
+ onSaveComplete: function () {
+ EditorOverlayBase.prototype.onSaveComplete.apply( this,
arguments );
this.clearSpinner();
this.destroyTarget();
},
--
To view, visit https://gerrit.wikimedia.org/r/181699
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c89a733f92f23daf7b35608c9dd345ec11898d2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
