jenkins-bot has submitted this change and it was merged.
Change subject: Remove this.$element on destroy but don't nullify
......................................................................
Remove this.$element on destroy but don't nullify
Bug: T84897
Change-Id: I794fa007358515022598dd3d66683beba94275a4
(cherry picked from commit 7bba15fba90590e32c763c30c2f08114937b8e8f)
---
M src/init/ve.init.Target.js
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/init/ve.init.Target.js b/src/init/ve.init.Target.js
index fb56863..8987dec 100644
--- a/src/init/ve.init.Target.js
+++ b/src/init/ve.init.Target.js
@@ -191,10 +191,7 @@
this.toolbar.destroy();
this.toolbar = null;
}
- if ( this.$element ) {
- this.$element.remove();
- this.$element = null;
- }
+ this.$element.remove();
this.unbindHandlers();
ve.init.target = null;
};
--
To view, visit https://gerrit.wikimedia.org/r/181901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I794fa007358515022598dd3d66683beba94275a4
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: wmf/1.25wmf13
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
