Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/181940
Change subject: Include log id api error response
......................................................................
Include log id api error response
For internal api error it is helpful for reporting when having the log
id under the exception was logged in the exception log.
Also use the redacted trace in the api error response instead of the
normal one to avoid leakage of function values.
Change-Id: I7d917e532da1b1c7979a6599425f07d2f4f35aed
---
M includes/api/ApiMain.php
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/40/181940/1
diff --git a/includes/api/ApiMain.php b/includes/api/ApiMain.php
index a5287b6..99f90ee 100644
--- a/includes/api/ApiMain.php
+++ b/includes/api/ApiMain.php
@@ -710,11 +710,13 @@
$errMessage = array(
'code' => 'internal_api_error_' . get_class( $e
),
- 'info' => $info,
+ 'info' => '[' . MWExceptionHandler::getLogId(
$e ) . '] ' . $info,
);
ApiResult::setContent(
$errMessage,
- $config->get( 'ShowExceptionDetails' ) ?
"\n\n{$e->getTraceAsString()}\n\n" : ''
+ $config->get( 'ShowExceptionDetails' )
+ ? "\n\n" .
MWExceptionHandler::getRedactedTraceAsString( $e ) . "\n\n"
+ : ''
);
}
--
To view, visit https://gerrit.wikimedia.org/r/181940
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d917e532da1b1c7979a6599425f07d2f4f35aed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
