Unicodesnowman has uploaded a new change for review.
https://gerrit.wikimedia.org/r/181946
Change subject: Make VipsScaler pass jshint
......................................................................
Make VipsScaler pass jshint
Add .jshintrc, .jshintignore, and make VipsScaler pass jshint.
Bug: T63643
Change-Id: If68db010926bb44ede55c701c85e40d5f026eb35
---
A .jshintignore
A .jshintrc
M modules/ext.vipsScaler/ext.vipsScaler.js
3 files changed, 24 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VipsScaler
refs/changes/46/181946/1
diff --git a/.jshintignore b/.jshintignore
new file mode 100644
index 0000000..872edba
--- /dev/null
+++ b/.jshintignore
@@ -0,0 +1 @@
+modules/jquery.ucompare/js/jquery.ucompare.js
diff --git a/.jshintrc b/.jshintrc
new file mode 100644
index 0000000..0e50536
--- /dev/null
+++ b/.jshintrc
@@ -0,0 +1,21 @@
+{
+ // Enforcing
+ "bitwise": true,
+ "eqeqeq": true,
+ "es3": true,
+ "latedef": true,
+ "noarg": true,
+ "nonew": true,
+ "undef": true,
+ "unused": true,
+ "strict": false,
+
+ // Environment
+ "browser": true,
+
+ "globals": {
+ "mediaWiki": false,
+ "jQuery": false,
+ "QUnit": false
+ }
+}
diff --git a/modules/ext.vipsScaler/ext.vipsScaler.js
b/modules/ext.vipsScaler/ext.vipsScaler.js
index ad4bf85..27945ef 100644
--- a/modules/ext.vipsScaler/ext.vipsScaler.js
+++ b/modules/ext.vipsScaler/ext.vipsScaler.js
@@ -1,7 +1,7 @@
jQuery( window ).load( ( function( $ ) {
'use strict';
- return function( event ) {
+ return function() {
$.vipsScaler = {
/** function to alternate between both thumbnails */
switchThumbs: function() {
@@ -36,7 +36,7 @@
defaultgap: 50,
leftgap: 0,
rightgap: 0,
- caption: true,
+ caption: true,
reveal: 0.5
});
--
To view, visit https://gerrit.wikimedia.org/r/181946
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If68db010926bb44ede55c701c85e40d5f026eb35
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VipsScaler
Gerrit-Branch: master
Gerrit-Owner: Unicodesnowman <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
