jenkins-bot has submitted this change and it was merged.
Change subject: Ignore events with modifier keys
......................................................................
Ignore events with modifier keys
I've combed through the entire codebase for keydown, keyup, keypress
and .which and I've only found one case where modifier keys are not
ignored for keyboard shortcuts.
Bug: T68329
Change-Id: I10ca2b89b9eb5addd7c706cf796331b5206d6bef
---
M resources/mmv/ui/mmv.ui.metadataPanelScroller.js
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Gergő Tisza: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mmv/ui/mmv.ui.metadataPanelScroller.js
b/resources/mmv/ui/mmv.ui.metadataPanelScroller.js
index 7cd9a8e..fa539ce 100644
--- a/resources/mmv/ui/mmv.ui.metadataPanelScroller.js
+++ b/resources/mmv/ui/mmv.ui.metadataPanelScroller.js
@@ -194,6 +194,9 @@
* Handles keydown events for this element.
*/
MPSP.keydown = function ( e ) {
+ if ( e.altKey || e.shiftKey || e.ctrlKey || e.metaKey ) {
+ return;
+ }
switch ( e.which ) {
case 40: // Down arrow
// fall through
--
To view, visit https://gerrit.wikimedia.org/r/182052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10ca2b89b9eb5addd7c706cf796331b5206d6bef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Unicodesnowman <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
