Jackmcbarn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/182091
Change subject: Restore backwards compatibility
......................................................................
Restore backwards compatibility
When status indicators were added, backwards compatibility was unnecessarily
broken. This makes things like looking at old non-rebased branches, or running
git bisect, unnecessarily annoying. This change adds an is_callable to restore
backwards compatibility and removes the version check that was added in response
to this break.
Change-Id: Ia05aa73a1b027e667c52f54b6d6fdf6f42bbbadf
---
M Vector.php
M VectorTemplate.php
2 files changed, 5 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector
refs/changes/91/182091/1
diff --git a/Vector.php b/Vector.php
index 784bf0b..4b7f95e 100644
--- a/Vector.php
+++ b/Vector.php
@@ -22,12 +22,6 @@
* @ingroup Skins
*/
-if ( version_compare( $GLOBALS['wgVersion'], '1.25c', '<' ) ) {
- echo 'This version of the Vector skin requires at least MediaWiki 1.25,
you have ' . $GLOBALS['wgVersion'] .
- '. You can download a more appropriate version here:
https://www.mediawiki.org/wiki/Special:SkinDistributor/Vector';
- exit();
-}
-
$GLOBALS['wgExtensionCredits']['skin'][] = array(
'path' => __FILE__,
'name' => 'Vector',
diff --git a/VectorTemplate.php b/VectorTemplate.php
index ab40693..4acfa8c 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -102,7 +102,11 @@
<?php
}
?>
- <?php echo $this->getIndicators(); ?>
+ <?php
+ if ( is_callable( array( $this, 'getIndicators' ) ) ) {
+ echo $this->getIndicators();
+ }
+ ?>
<h1 id="firstHeading" class="firstHeading" lang="<?php
$this->data['pageLanguage'] =
$this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode();
--
To view, visit https://gerrit.wikimedia.org/r/182091
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia05aa73a1b027e667c52f54b6d6fdf6f42bbbadf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Jackmcbarn <jackmcb...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
