AndyRussG has uploaded a new change for review.
https://gerrit.wikimedia.org/r/182137
Change subject: Add comment non-funcitonal code for mobile URLs
......................................................................
Add comment non-funcitonal code for mobile URLs
Change-Id: Ibdf9e657ca96ded7b5e20c4043d19e831429b5cb
---
M CentralNotice.hooks.php
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/37/182137/1
diff --git a/CentralNotice.hooks.php b/CentralNotice.hooks.php
index 8a05861..d72f96b 100644
--- a/CentralNotice.hooks.php
+++ b/CentralNotice.hooks.php
@@ -330,6 +330,9 @@
$wgCentralBannerRecorder = SpecialPage::getTitleFor(
'RecordImpression' )->getLocalUrl();
}
+ // FIXME Dicey code! It is likely that the following is never executed
in
+ // the WMF's setup. Also getMobileUrl() may not work in some cases.
+
// Mangle infrastructure URLs for mobile use -- this should always be
last.
if ( class_exists( 'MobileContext' ) ) {
// Where possible; make things mobile friendly
--
To view, visit https://gerrit.wikimedia.org/r/182137
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdf9e657ca96ded7b5e20c4043d19e831429b5cb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
