Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/182293
Change subject: mediawiki.action.edit.preview: Wrap content preview with
mw-content-*
......................................................................
mediawiki.action.edit.preview: Wrap content preview with mw-content-*
Todo: For RTL wgPageContentLanguage mw-content-rtl should be used.
Bug: T85531
Change-Id: I78f6b82972621da8dddc24f0d6d6b2293f7d8876
---
M resources/src/mediawiki.action/mediawiki.action.edit.preview.js
1 file changed, 15 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/93/182293/1
diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
index 42ba5aa..9076986 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
@@ -108,7 +108,7 @@
}
request = api.post( postData );
request.done( function ( response ) {
- var li, newList, $next, $parent, $list;
+ var li, newList, $parent, $list, $content;
if ( response.parse.modules ) {
mw.loader.load(
response.parse.modules.concat(
response.parse.modulescripts,
@@ -162,23 +162,23 @@
}
if ( response.parse.text['*'] ) {
- $next = $wikiPreview.next();
- // If there is no next node, use parent
instead.
- // Only query parent if needed, false
otherwise.
- $parent = !$next.length &&
$wikiPreview.parent();
+ // Remove elements of the previous
content preview
+ $wikiPreview.empty();
- $wikiPreview
- .detach()
- .html( response.parse.text['*']
);
+ // Create a new element for the content
preview
+ $content = $( '<div>' )
+ .attr( {
+ // TODO: Use 'rtl' for RTL
languages
+ 'class': 'mw-content-ltr',
+ 'dir': 'ltr',
+ 'lang': mw.config.get(
'wgPageContentLanguage' )
+ } )
+ .html( response.parse.text['*'] );
- mw.hook( 'wikipage.content' ).fire(
$wikiPreview );
+ mw.hook( 'wikipage.content' ).fire(
$content );
- // Reattach
- if ( $parent ) {
- $parent.append( $wikiPreview );
- } else {
- $next.before( $wikiPreview );
- }
+ $content.appendTo( $wikiPreview );
+
$wikiPreview.show();
}
--
To view, visit https://gerrit.wikimedia.org/r/182293
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78f6b82972621da8dddc24f0d6d6b2293f7d8876
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
