Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/182354
Change subject: mediawiki.action.edit.preview: Use DOM as event priority
......................................................................
mediawiki.action.edit.preview: Use DOM as event priority
Use 'submit' instead of 'click' event.
$( document ).on( 'submit', '#editform', callback )
gets triggerd after
$( '#editform' ).on( 'submit', callback )
in extension CodeEditor.
Remove $( mw ).trigger( 'LivePreviewPrepare' );
Change-Id: I9a609639facff1efbd52519451f6746b2b62efbe
---
M resources/src/mediawiki.action/mediawiki.action.edit.preview.js
1 file changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/54/182354/1
diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
index 9bf1352..a666236 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js
@@ -3,6 +3,7 @@
*/
( function ( mw, $ ) {
+ var submit = null;
/**
* @ignore
* @param {jQuery.Event} e
@@ -11,12 +12,14 @@
var isDiff, api, request, postData, copySelectors, section,
$wikiPreview, $wikiDiff, $editform, $copyElements,
$spinner;
+ if ( !submit ) {
+ return;
+ }
+ isDiff = ( submit.name === 'wpDiff' );
+ submit = null;
+
e.preventDefault();
- // Deprecated: Use mw.hook instead
- $( mw ).trigger( 'LivePreviewPrepare' );
-
- isDiff = ( e.target.name === 'wpDiff' );
$wikiPreview = $( '#wikiPreview' );
$wikiDiff = $( '#wikiDiff' );
$editform = $( '#editform' );
@@ -253,10 +256,14 @@
);
}
+ // Remember the clicked submit button
+ $( '#wpPreview, #wpDiff' ).click( function () {
+ submit = this;
+ } );
// This should be moved down to '#editform', but is kept on the
body for now
// because the LiquidThreads extension is re-using this module
with only half
// the EditPage (doesn't include #editform presumably, bug
55463).
- $( document.body ).on( 'click', '#wpPreview, #wpDiff',
doLivePreview );
+ $( document ).on( 'submit', '#editform', doLivePreview );
} );
}( mediaWiki, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/182354
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a609639facff1efbd52519451f6746b2b62efbe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
