Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/182355
Change subject: Remove trigger 'LivePreviewPrepare'
......................................................................
Remove trigger 'LivePreviewPrepare'
Since I9a609639facff1efbd52519451f6746b2b62efbe
the .submit() gets triggered before submit in LivePreview.
Change-Id: Iae54a2422ff1814f8858723d51fcb10d04645c51
---
M modules/jquery.codeEditor.js
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeEditor
refs/changes/55/182355/1
diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js
index e0c4803..fc45134 100644
--- a/modules/jquery.codeEditor.js
+++ b/modules/jquery.codeEditor.js
@@ -224,10 +224,6 @@
if ( mw.hook ) {
mw.hook( 'codeEditor.configure'
).fire( session );
}
- // Old, deprecated style for backwards
compat
- // Do this even if mw.hook exists,
because the caller wasn't
- // updated right away to actually use
the new style.
- $( mw ).bind( 'LivePreviewPrepare',
context.evt.codeEditorSubmit );
ace.config.loadModule( 'ace/mode/' +
lang, function () {
AceLangMode = require(
'ace/mode/' + lang ).Mode;
@@ -263,7 +259,6 @@
'disableCodeEditor': function () {
// Kills it!
context.$textarea.closest( 'form' ).unbind(
'submit', context.evt.codeEditorSubmit );
- $( mw ).unbind( 'LivePreviewPrepare',
context.evt.codeEditorSubmit ); // deprecated
// Save contents
context.$textarea.textSelection( 'unregister' );
--
To view, visit https://gerrit.wikimedia.org/r/182355
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae54a2422ff1814f8858723d51fcb10d04645c51
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
