jenkins-bot has submitted this change and it was merged.
Change subject: Remove normalizeAttributeValue()
......................................................................
Remove normalizeAttributeValue()
Sanitizer::normalizeAttributeValue is completely unused and private, and
as such, should be removed
Change-Id: I655ef90fe97a775011f9d16c0b51feb2612aec26
---
M includes/Sanitizer.php
1 file changed, 0 insertions(+), 18 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Sanitizer.php b/includes/Sanitizer.php
index 11c30a2..d35bbec 100644
--- a/includes/Sanitizer.php
+++ b/includes/Sanitizer.php
@@ -1268,24 +1268,6 @@
}
/**
- * Normalize whitespace and character references in an XML source-
- * encoded text for an attribute value.
- *
- * See http://www.w3.org/TR/REC-xml/#AVNormalize for background,
- * but note that we're not returning the value, but are returning
- * XML source fragments that will be slapped into output.
- *
- * @param string $text
- * @return string
- * @todo Remove, unused?
- */
- private static function normalizeAttributeValue( $text ) {
- return str_replace( '"', '"',
- self::normalizeWhitespace(
- Sanitizer::normalizeCharReferences( $text ) ) );
- }
-
- /**
* @param string $text
* @return string
*/
--
To view, visit https://gerrit.wikimedia.org/r/181954
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I655ef90fe97a775011f9d16c0b51feb2612aec26
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: McIntireEvan <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: McIntireEvan <[email protected]>
Gerrit-Reviewer: PleaseStand <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
