Dbrant has submitted this change and it was merged.
Change subject: Don't export activities (except PageActivity)
......................................................................
Don't export activities (except PageActivity)
For the below mentioned it looks like another app was able
to start one of our activities using an implicit intent.
By not exporting the activity this should not be possible anymore.
In the future we may chose to export some activities but this should
be done intentionally.
Bug: T85510
Change-Id: Idaf2564e07866150a12beaecafed6eed3fd981af
---
M wikipedia/AndroidManifest.xml
1 file changed, 16 insertions(+), 4 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
diff --git a/wikipedia/AndroidManifest.xml b/wikipedia/AndroidManifest.xml
index 86607bd..3daeb88 100644
--- a/wikipedia/AndroidManifest.xml
+++ b/wikipedia/AndroidManifest.xml
@@ -61,13 +61,17 @@
<activity android:name="org.acra.CrashReportDialog"
android:launchMode="singleInstance"
android:excludeFromRecents="true"
- android:finishOnTaskLaunch="true" />
+ android:finishOnTaskLaunch="true"
+ android:exported="false"
+ />
<activity android:name=".settings.SettingsActivity"
android:label="@string/more_activity_title"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize"
+ android:exported="false"
/>
<activity android:name=".settings.AboutActivity"
- android:label="@string/about_activity_title">
+ android:label="@string/about_activity_title"
+ android:exported="false">
<intent-filter>
<action android:name=".settings.AboutActivity" />
<category android:name="android.intent.category.DEFAULT" />
@@ -76,32 +80,40 @@
<activity android:name=".interlanguage.LangLinksActivity"
android:label="@string/langlinks_activity_title"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize"
+ android:exported="false"
/>
<activity android:name=".editing.EditSectionActivity"
android:windowSoftInputMode="adjustResize|stateVisible"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize"
+ android:exported="false"
/>
<activity android:name=".login.LoginActivity"
android:label="@string/login_activity_title"
android:windowSoftInputMode="stateVisible|adjustResize"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize"
+ android:exported="false"
/>
<activity android:name=".createaccount.CreateAccountActivity"
android:label="@string/create_account_activity_title"
android:windowSoftInputMode="stateVisible|adjustResize"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize"
+ android:exported="false"
/>
<activity
android:name=".pagehistory.usercontributions.UserContribsActivity"
android:label="@string/activity_my_contributions_title"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize"
- />
+ android:exported="false"
+ />
<activity android:name=".onboarding.OnboardingActivity"
android:theme="@style/NoTitle"
+ android:exported="false"
/>
<activity android:name=".page.gallery.GalleryActivity"
android:theme="@style/NoTitle"
+ android:exported="false"
/>
- <activity android:name=".settings.LicenseActivity">
+ <activity android:name=".settings.LicenseActivity"
+ android:exported="false">
<intent-filter>
<action android:name="android.intent.action.VIEW" />
<category android:name="android.intent.category.DEFAULT"/>
--
To view, visit https://gerrit.wikimedia.org/r/182146
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idaf2564e07866150a12beaecafed6eed3fd981af
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
