jenkins-bot has submitted this change and it was merged. Change subject: QA: back button workaround for Safari ......................................................................
QA: back button workaround for Safari Bug T85802 Change-Id: I4a3b360ffddbab5c22ca1eb3b03c45159425de70 --- M tests/browser/features/step_definitions/mmv_navigation_steps.rb 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Gilles: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/mmv_navigation_steps.rb b/tests/browser/features/step_definitions/mmv_navigation_steps.rb index 5d83e63..522e100 100644 --- a/tests/browser/features/step_definitions/mmv_navigation_steps.rb +++ b/tests/browser/features/step_definitions/mmv_navigation_steps.rb @@ -9,7 +9,8 @@ end When /^I press the browser back button$/ do - $browser.back + # $browser.back doesn't work for Safari. This is a workaround for https://code.google.com/p/selenium/issues/detail?id=3771 + on(E2ETestPage).execute_script("window.history.back();"); end Then /^the image and metadata of the next image should appear$/ do -- To view, visit https://gerrit.wikimedia.org/r/182828 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a3b360ffddbab5c22ca1eb3b03c45159425de70 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> Gerrit-Reviewer: Gilles <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
