Yuvipanda has submitted this change and it was merged.
Change subject: maintain-replicas: Use consistent IFs to redact info
......................................................................
maintain-replicas: Use consistent IFs to redact info
Everything else is IF(condition-to-null-on, null, original), except
for ipblocks. This messed with labsdb-auditor, so fixing to
be consistent with the other tables.
Change-Id: I34938c8d54d787e6eeeadb40cf88f4267de96ced
---
M maintain-replicas/maintain-replicas.pl
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Yuvipanda: Looks good to me, approved
coren: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/maintain-replicas/maintain-replicas.pl
b/maintain-replicas/maintain-replicas.pl
index 90da47f..acf3340 100755
--- a/maintain-replicas/maintain-replicas.pl
+++ b/maintain-replicas/maintain-replicas.pl
@@ -180,10 +180,10 @@
'ipblocks' => {
'source' => 'ipblocks',
- 'view' => 'select ipb_id, if(ipb_auto=0,ipb_address,null) as
ipb_address, ipb_user,
+ 'view' => 'select ipb_id, if(ipb_auto<>0,null,ipb_address) as
ipb_address, ipb_user,
ipb_by, ipb_reason, ipb_timestamp, ipb_auto,
ipb_anon_only, ipb_create_account,
- ipb_expiry, if(ipb_auto=0,ipb_range_start,null) as
ipb_range_start,
- if(ipb_auto=0,ipb_range_end,null) as ipb_range_end,
ipb_enable_autoblock,
+ ipb_expiry, if(ipb_auto<>0,null,ipb_range_start) as
ipb_range_start,
+ if(ipb_auto<>0,null,ipb_range_end) as ipb_range_end,
ipb_enable_autoblock,
ipb_deleted, ipb_block_email, ipb_by_text,
ipb_allow_usertalk, ipb_parent_block_id',
'where' => 'ipb_deleted=0' },
--
To view, visit https://gerrit.wikimedia.org/r/182819
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34938c8d54d787e6eeeadb40cf88f4267de96ced
Gerrit-PatchSet: 2
Gerrit-Project: operations/software
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: coren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
