jenkins-bot has submitted this change and it was merged.
Change subject: Stop using jQuery.live
......................................................................
Stop using jQuery.live
It was removed in jQuery 1.9
Also, a small required autoloader fix to make Jenkins pass.
Bug: T85300
Change-Id: I688a69fcbb55933bb221fc9096a495de42f97ddf
(cherry picked from commit f53268f94f2f3571ee1eb10feeea9bfa1d8b658a)
---
M MoodBar.php
M modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js
2 files changed, 11 insertions(+), 9 deletions(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MoodBar.php b/MoodBar.php
index 6cc167c..c54629b 100644
--- a/MoodBar.php
+++ b/MoodBar.php
@@ -49,6 +49,7 @@
// Special pages
$wgAutoloadClasses['SpecialMoodBar'] = $moodBarDir . 'SpecialMoodBar.php';
+$wgAutoloadClasses['MoodBarPager'] = $moodBarDir . 'SpecialMoodBar.php';
$wgSpecialPages['MoodBar'] = 'SpecialMoodBar';
$wgAutoloadClasses['SpecialFeedbackDashboard'] = $moodBarDir .
'SpecialFeedbackDashboard.php';
$wgSpecialPages['FeedbackDashboard'] = 'SpecialFeedbackDashboard';
diff --git a/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js
b/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js
index 9113af5..57dddde 100644
--- a/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js
+++ b/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js
@@ -696,8 +696,8 @@
$item.find( '.fbd-item-response' ).append( $tooltip );
// Close event, closure remembers object
- $( '.fbd-tooltip-close' )
- .live( 'click' , function () {
+ $( document )
+ .on( 'click', '.fbd-tooltip-close', function () {
$tooltip.remove();
} );
@@ -709,21 +709,22 @@
}
// On-load stuff
- $( '.fbd-item-show a' ).live( 'click', showHiddenItem );
- $( '.fbd-item-hide a' ).live( 'click', hideItem );
- $( '.fbd-item-delete a' ).live( 'click', deleteItem );
- $( '.fbd-item-restore' ).live( 'click', restoreItem );
- $( '.fbd-respond-link' ).live ( 'click', showResponseForm );
+ $( document )
+ .on( 'click', '.fbd-item-show a', showHiddenItem )
+ .on( 'click', '.fbd-item-hide a', hideItem )
+ .on( 'click', '.fbd-item-delete a', deleteItem )
+ .on( 'click', '.fbd-item-restore', restoreItem )
+ .on( 'click', '.fbd-respond-link', showResponseForm );
// Handle preview back button
- $( '.fbd-response-preview-back' ).live( 'click', function () {
+ $( document ).on( 'click', '.fbd-response-preview-back', function () {
var $item = $(this).parent().parent();
$item.find( '.fbd-response-submit, .fbd-response-wikitext,
.fbd-response-preview-back, .ula' ).hide();
$item.find( '.fbd-response-preview, .fbd-response-text'
).show();
});
// Handle response submit
- $( '.fbd-response-submit' ).live( 'click', function () {
+ $( document ).on( 'click', '.fbd-response-submit', function () {
var $item, fbResponse, clientData, item_id, resData,
$responseStatus, $responseForm;
$item = $(this).parent().parent();
--
To view, visit https://gerrit.wikimedia.org/r/182871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I688a69fcbb55933bb221fc9096a495de42f97ddf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MoodBar
Gerrit-Branch: wmf/1.25wmf12
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
