20after4 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/182977
Change subject: don't 'return' when security field is 'default' unless is_new
is true
......................................................................
don't 'return' when security field is 'default' unless is_new is true
Change-Id: I065b890c6408c7814ec55b1b5ce54aa13f20d5bb
---
M src/policy/SecurityPolicyListener.php
M src/policy/WMFSecurityPolicy.php
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/phabricator/extensions/security
refs/changes/77/182977/1
diff --git a/src/policy/SecurityPolicyListener.php
b/src/policy/SecurityPolicyListener.php
index 7dcffc2..e6f4392 100644
--- a/src/policy/SecurityPolicyListener.php
+++ b/src/policy/SecurityPolicyListener.php
@@ -27,7 +27,7 @@
$type_hasproj = PhabricatorProjectObjectHasProjectEdgeType::EDGECONST;
$security_setting = WMFSecurityPolicy::getSecurityFieldValue($task);
- if ($security_setting == 'none' || $security_setting == 'default') {
+ if ($is_new && $security_setting == 'default') {
return;
}
diff --git a/src/policy/WMFSecurityPolicy.php b/src/policy/WMFSecurityPolicy.php
index 19540c8..9ab8447 100644
--- a/src/policy/WMFSecurityPolicy.php
+++ b/src/policy/WMFSecurityPolicy.php
@@ -78,7 +78,7 @@
break;
}
}
- return $transactions;
+ return array_values($transactions);
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/182977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I065b890c6408c7814ec55b1b5ce54aa13f20d5bb
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/security
Gerrit-Branch: master
Gerrit-Owner: 20after4 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
