Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/182992
Change subject: "Un-disable" xhprof
......................................................................
"Un-disable" xhprof
We haven't gotten down to the bottom of why enabling xhprof on a sample of
requests caused crashes on the cluster, but with the Xenon / flame-graph setup
we don't have as much need for that anymore. The one thing we do need xhprof
for is for manually forcing profiling of a specific requests, via the
'forceprofile=1' magic URL parameter. This feature is used infrequently, so it
is less likely to get us into trouble.
Change I341a50bef removed the code that enables automatic profiling of a
fraction of requests. This is the companion change that would make xhprof
available for forceprofile requests again.
Change-Id: Ia042f899a99a45601028ff45edb6b76ff01dc5d9
---
M modules/mediawiki/manifests/hhvm.pp
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/92/182992/1
diff --git a/modules/mediawiki/manifests/hhvm.pp
b/modules/mediawiki/manifests/hhvm.pp
index c2fd930..6f1b344 100644
--- a/modules/mediawiki/manifests/hhvm.pp
+++ b/modules/mediawiki/manifests/hhvm.pp
@@ -37,9 +37,6 @@
request_init_document =>
'/srv/mediawiki/wmf-config/HHVMRequestInit.php',
thread_count => $max_threads,
},
- stats => {
- enable_hot_profiler => false,
- }
},
},
}
--
To view, visit https://gerrit.wikimedia.org/r/182992
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia042f899a99a45601028ff45edb6b76ff01dc5d9
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
