Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/182995
Change subject: Honor navigator.doNotTrack
......................................................................
Honor navigator.doNotTrack
Change-Id: I17ee55f464743580b18f6e594fdfc73a3d76f1cf
---
M modules/ext.eventLogging.core.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging
refs/changes/95/182995/1
diff --git a/modules/ext.eventLogging.core.js b/modules/ext.eventLogging.core.js
index 6ea8b65..e9c1133 100644
--- a/modules/ext.eventLogging.core.js
+++ b/modules/ext.eventLogging.core.js
@@ -212,11 +212,14 @@
* Transfer data to a remote server by making a lightweight HTTP
* request to the specified URL.
*
+ * If the user expressed a preference not to be tracked, or if
+ * $wgEventLoggingBaseUri is unset, this method is a no-op.
+ *
* @method sendBeacon
* @param {String} url URL to request from the server.
* @return undefined
*/
- sendBeacon: !baseUrl
+ sendBeacon: /1|yes/.test( navigator.doNotTrack ) || !baseUrl
? $.noop
: navigator.sendBeacon
? function ( url ) { navigator.sendBeacon( url
); }
--
To view, visit https://gerrit.wikimedia.org/r/182995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17ee55f464743580b18f6e594fdfc73a3d76f1cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
