Phuedx has uploaded a new change for review.
https://gerrit.wikimedia.org/r/183038
Change subject: Disable red links in beta
......................................................................
Disable red links in beta
* Disable red links in stable and beta for all users
* Enable red links in alpha for all users
* Update the corresponding SkinMinerva tests
Change-Id: Ib8438a4d8a936e76ac0b1bed06197828c2cee465
---
M includes/skins/SkinMinerva.php
M tests/phpunit/skins/SkinMinervaTest.php
2 files changed, 19 insertions(+), 17 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/38/183038/1
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 37f197a..e077eed 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -873,15 +873,7 @@
// init with false
$vars['wgMFShowRedLinks'] = false;
- // in beta redlinks are visible for logged in users (no matter
what config vars say)
- if ( $this->mobileContext->isBetaGroupMember() ) {
- if ( $user->isLoggedIn() ) {
- $vars['wgMFShowRedLinks'] = true;
- }
- } elseif (
- ( $wgMFShowRedLinks && $user->isLoggedIn() ) // ...for
logged in users
- || ( $wgMFShowRedLinksAnon && $user->isAnon() ) //
...for anonymous users
- ) {
+ if ( $this->mobileContext->isAlphaGroupMember() ) {
$vars['wgMFShowRedLinks'] = true;
}
diff --git a/tests/phpunit/skins/SkinMinervaTest.php
b/tests/phpunit/skins/SkinMinervaTest.php
index 0e443e6..f0b5e06 100644
--- a/tests/phpunit/skins/SkinMinervaTest.php
+++ b/tests/phpunit/skins/SkinMinervaTest.php
@@ -49,23 +49,33 @@
return array(
// test in stable mode
array( false, false, 'stable', 'UTSysop', false ),
- array( true, false, 'stable', 'UTSysop', true ),
+ array( true, false, 'stable', 'UTSysop', false ),
array( false, true, 'stable', 'UTSysop', false ),
- array( true, true, 'stable', 'UTSysop', true ),
+ array( true, true, 'stable', 'UTSysop', false ),
array( false, false, 'stable', 'NotLoggedIn', false ),
array( true, false, 'stable', 'NotLoggedIn', false ),
- array( false, true, 'stable', 'NotLoggedIn', true ),
- array( true, true, 'stable', 'NotLoggedIn', true ),
+ array( false, true, 'stable', 'NotLoggedIn', false ),
+ array( true, true, 'stable', 'NotLoggedIn', false ),
// test in beta mode
array( false, false, 'beta', 'NotLoggedIn', false ),
array( true, false, 'beta', 'NotLoggedIn', false ),
array( false, true, 'beta', 'NotLoggedIn', false ),
array( true, true, 'beta', 'NotLoggedIn', false ),
- array( false, false, 'beta', 'UTSysop', true ),
- array( true, false, 'beta', 'UTSysop', true ),
- array( false, true, 'beta', 'UTSysop', true ),
- array( true, true, 'beta', 'UTSysop', true ),
+ array( false, false, 'beta', 'UTSysop', false ),
+ array( true, false, 'beta', 'UTSysop', false ),
+ array( false, true, 'beta', 'UTSysop', false ),
+ array( true, true, 'beta', 'UTSysop', false ),
+
+ // test in alpha mode
+ array( false, false, 'alpha', 'NotLoggedIn', true ),
+ array( true, false, 'alpha', 'NotLoggedIn', true ),
+ array( false, true, 'alpha', 'NotLoggedIn', true ),
+ array( true, true, 'alpha', 'NotLoggedIn', true ),
+ array( false, false, 'alpha', 'UTSysop', true ),
+ array( true, false, 'alpha', 'UTSysop', true ),
+ array( false, true, 'alpha', 'UTSysop', true ),
+ array( true, true, 'alpha', 'UTSysop', true ),
);
}
}
--
To view, visit https://gerrit.wikimedia.org/r/183038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8438a4d8a936e76ac0b1bed06197828c2cee465
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
