Catrope has submitted this change and it was merged.
Change subject: Update setupToolbar signature in mobile target
......................................................................
Update setupToolbar signature in mobile target
This method now takes arguments to make sure they are passed.
Looks like we missed this commit, it was supposed to be cherry-picked.
Bug: T78710
Bug: T85897
Change-Id: Ifba696c2a1b60690bdccd1b58d347c254dec5432
(cherry picked from commit f49bbf783ab68fd839725a4bee6454eea5255db4)
---
M modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Catrope: Verified; Looks good to me, approved
diff --git a/modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js
index 4d33392..a81b649 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js
@@ -84,9 +84,9 @@
/**
* @inheritdoc
*/
-ve.init.mw.MobileViewTarget.prototype.setupToolbar = function () {
+ve.init.mw.MobileViewTarget.prototype.setupToolbar = function ( surface ) {
// Parent method
- ve.init.mw.Target.prototype.setupToolbar.call( this );
+ ve.init.mw.Target.prototype.setupToolbar.call( this, surface );
this.toolbar.$element
// FIXME shouldn't be using viewPageTarget styles
--
To view, visit https://gerrit.wikimedia.org/r/182993
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifba696c2a1b60690bdccd1b58d347c254dec5432
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.25wmf13
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
