jenkins-bot has submitted this change and it was merged. Change subject: Use string.endswith() instead of a regex ......................................................................
Use string.endswith() instead of a regex https://xkcd.com/1171/ Change-Id: I2ea544cc44306c78cbaaca38ced093d5a59acb3d --- M tests/test_zuul_layout.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Krinkle: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/test_zuul_layout.py b/tests/test_zuul_layout.py index d150aca..50c1719 100644 --- a/tests/test_zuul_layout.py +++ b/tests/test_zuul_layout.py @@ -130,7 +130,7 @@ self.assertTrue( ('php-composer-validate' in project_def[pipeline]) or any( [job for job in project_def[pipeline] - if re.search('-composer$', job)]), + if job.endswith('-composer')]), 'Project %s pipeline %s must have either ' 'php-composer-validate or a *-composer job' % (mw_project, pipeline)) -- To view, visit https://gerrit.wikimedia.org/r/183079 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ea544cc44306c78cbaaca38ced093d5a59acb3d Gerrit-PatchSet: 1 Gerrit-Project: integration/config Gerrit-Branch: master Gerrit-Owner: Legoktm <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
