jenkins-bot has submitted this change and it was merged.
Change subject: Fix documentation of inherited ve.ce.ContentBranchNode methods
......................................................................
Fix documentation of inherited ve.ce.ContentBranchNode methods
* Fix classes which inherit ve.ce.ContentBranchNode
* Update usage notes on CE blur hack
Change-Id: I56759fa2696f736eb1e5007f8e610d339d9ef457
---
M src/ce/nodes/ve.ce.BlockquoteNode.js
M src/ce/nodes/ve.ce.HeadingNode.js
M src/ce/nodes/ve.ce.ParagraphNode.js
M src/ce/nodes/ve.ce.PreformattedNode.js
M src/ce/ve.ce.Surface.js
5 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/nodes/ve.ce.BlockquoteNode.js
b/src/ce/nodes/ve.ce.BlockquoteNode.js
index 1197580..93ce063 100644
--- a/src/ce/nodes/ve.ce.BlockquoteNode.js
+++ b/src/ce/nodes/ve.ce.BlockquoteNode.js
@@ -9,7 +9,7 @@
* ContentEditable Blockquote node.
*
* @class
- * @extends ve.ce.BranchNode
+ * @extends ve.ce.ContentBranchNode
* @constructor
* @param {ve.dm.BlockquoteNode} model Model to observe
* @param {Object} [config] Configuration options
diff --git a/src/ce/nodes/ve.ce.HeadingNode.js
b/src/ce/nodes/ve.ce.HeadingNode.js
index b47a846..baa0779 100644
--- a/src/ce/nodes/ve.ce.HeadingNode.js
+++ b/src/ce/nodes/ve.ce.HeadingNode.js
@@ -8,7 +8,7 @@
* ContentEditable heading node.
*
* @class
- * @extends ve.ce.BranchNode
+ * @extends ve.ce.ContentBranchNode
* @constructor
* @param {ve.dm.HeadingNode} model Model to observe
* @param {Object} [config] Configuration options
diff --git a/src/ce/nodes/ve.ce.ParagraphNode.js
b/src/ce/nodes/ve.ce.ParagraphNode.js
index 1dd7030..59576d3 100644
--- a/src/ce/nodes/ve.ce.ParagraphNode.js
+++ b/src/ce/nodes/ve.ce.ParagraphNode.js
@@ -8,7 +8,7 @@
* ContentEditable paragraph node.
*
* @class
- * @extends ve.ce.BranchNode
+ * @extends ve.ce.ContentBranchNode
* @constructor
* @param {ve.dm.ParagraphNode} model Model to observe
* @param {Object} [config] Configuration options
diff --git a/src/ce/nodes/ve.ce.PreformattedNode.js
b/src/ce/nodes/ve.ce.PreformattedNode.js
index f5fb39f..f83df7f 100644
--- a/src/ce/nodes/ve.ce.PreformattedNode.js
+++ b/src/ce/nodes/ve.ce.PreformattedNode.js
@@ -8,7 +8,7 @@
* ContentEditable preformatted node.
*
* @class
- * @extends ve.ce.BranchNode
+ * @extends ve.ce.ContentBranchNode
* @constructor
* @param {ve.dm.PreformattedNode} model Model to observe
* @param {Object} [config] Configuration options
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index ea0c317..af6184e 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -292,7 +292,8 @@
// Disconnect DOM events on the window
this.$window.off( 'resize', this.onWindowResizeHandler );
- // HACK: Blur to make selection/cursor disappear (needed in Firefox in
some cases)
+ // HACK: Blur to make selection/cursor disappear (needed in Firefox
+ // in some cases, and in iOS to hide the keyboard)
this.$documentNode[0].blur();
// Remove DOM elements (also disconnects their events)
--
To view, visit https://gerrit.wikimedia.org/r/181620
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56759fa2696f736eb1e5007f8e610d339d9ef457
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
