jenkins-bot has submitted this change and it was merged.
Change subject: Don't attempt to render deactivated selections when collapsed
......................................................................
Don't attempt to render deactivated selections when collapsed
Currently results in a single pixel blue box. Deactivated selections
don't show the cursor position.
Change-Id: I96d2dbe45ea566d1fbc78336d79ea44aea23b29c
---
M src/ce/ve.ce.Surface.js
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 1f9d236..d8cccbf 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -691,7 +691,11 @@
this.$deactivatedSelection.empty();
- if ( !this.deactivated || this.focusedNode || !( selection instanceof
ve.dm.LinearSelection ) ) {
+ if (
+ !this.deactivated || this.focusedNode ||
+ !( selection instanceof ve.dm.LinearSelection ) ||
+ selection.isCollapsed()
+ ) {
return;
}
rects = this.getSelectionRects( selection );
--
To view, visit https://gerrit.wikimedia.org/r/183043
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96d2dbe45ea566d1fbc78336d79ea44aea23b29c
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
