jenkins-bot has submitted this change and it was merged.
Change subject: overlay: Remove needless specifity in .mw-echo-grey-link
selector
......................................................................
overlay: Remove needless specifity in .mw-echo-grey-link selector
Binding it to the element name should rarely be needed as it only
adds complexity with no clear benefit.
Nesting classes should also rarely be necessary as it basically
requires the code will never be embedded in or itself embed something
from another component (otherwise you'd clash with that other component's
class name, and if you don't clash, then it wasn't neccecary to
nest the class in the first place).
If the class is overlay-specfic it should be renamed to something
like '.mw-echo-overlay-grey-link'. Keeping it as-is and applying
directly though, as it doesn't appear overlay-specific.
Change-Id: Ied601058c8e501914113d542f88542c83157d5a0
---
M modules/overlay/ext.echo.overlay.less
1 file changed, 3 insertions(+), 5 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/overlay/ext.echo.overlay.less
b/modules/overlay/ext.echo.overlay.less
index 41b2064..43b5e80 100644
--- a/modules/overlay/ext.echo.overlay.less
+++ b/modules/overlay/ext.echo.overlay.less
@@ -47,10 +47,6 @@
}
}
- a.mw-echo-grey-link {
- color: @colorTextLight;
- }
-
.mw-echo-notifications,
ul {
overflow: auto;
@@ -135,7 +131,9 @@
}
}
-
+.mw-echo-grey-link {
+ color: @colorTextLight;
+}
.mw-echo-notification-primary-link {
display: none;
--
To view, visit https://gerrit.wikimedia.org/r/183154
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied601058c8e501914113d542f88542c83157d5a0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
