Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/183164
Change subject: One QUnit test per allocation fixture
......................................................................
One QUnit test per allocation fixture
Change-Id: I18dc3a6cb15d1b66b49a33088f3cf6c4e833054c
---
M
tests/qunit/ext.centralNotice.bannerController.lib/bannerController.lib.tests.js
1 file changed, 6 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/64/183164/1
diff --git
a/tests/qunit/ext.centralNotice.bannerController.lib/bannerController.lib.tests.js
b/tests/qunit/ext.centralNotice.bannerController.lib/bannerController.lib.tests.js
index a18b257..19190d9 100644
---
a/tests/qunit/ext.centralNotice.bannerController.lib/bannerController.lib.tests.js
+++
b/tests/qunit/ext.centralNotice.bannerController.lib/bannerController.lib.tests.js
@@ -24,15 +24,14 @@
}
} ) );
- QUnit.test( 'allocations test cases', function( assert ) {
+ var testFixtures = mw.centralNoticeTestFixtures,
+ testCases = testFixtures.testCases,
+ lib = mw.cnBannerControllerLib;
- var testFixtures = mw.centralNoticeTestFixtures,
- testCases = testFixtures.testCases,
- lib = mw.cnBannerControllerLib;
+ // FIXME: fail hard if there is no fixture data
- QUnit.expect( Object.keys( testCases ).length );
-
- $.each( testCases, function( testCaseName, testCase ) {
+ $.each( testCases, function( testCaseName, testCase ) {
+ QUnit.test( testCaseName, 1, function( assert ) {
var choices,
choice,
i,
--
To view, visit https://gerrit.wikimedia.org/r/183164
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I18dc3a6cb15d1b66b49a33088f3cf6c4e833054c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
