jenkins-bot has submitted this change and it was merged.
Change subject: Remove the 'top' definition from .mw-ui-icon-element:before
......................................................................
Remove the 'top' definition from .mw-ui-icon-element:before
This was making the icon stick to the top of the button it was
inside. We couldn't find an example of the issue that the earlier
patch was trying to fix (on #wikimedia-mobile).
Bug: T85778
Change-Id: Ifea204ee9b86b01f61f3c48372619dadce64da9b
Reverts: Iadd741f02155a9b5ddeb6cd8ff64fa13ae5506d7
---
M resources/src/mediawiki.ui/components/icons.less
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.ui/components/icons.less
b/resources/src/mediawiki.ui/components/icons.less
index 40d1723..0912554 100644
--- a/resources/src/mediawiki.ui/components/icons.less
+++ b/resources/src/mediawiki.ui/components/icons.less
@@ -49,7 +49,6 @@
min-width: @width;
max-width: @width;
&:before {
- top: 0;
left: 0;
right: 0;
position: absolute;
--
To view, visit https://gerrit.wikimedia.org/r/183176
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifea204ee9b86b01f61f3c48372619dadce64da9b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
