jenkins-bot has submitted this change and it was merged.
Change subject: Add task link to grrrit-wm irc message
......................................................................
Add task link to grrrit-wm irc message
If a "Bug: Txxxx" exists in commit message,
show a link to that phab task in irc message.
Basically, Ief464e4ceb3cb268b935e130290994b8b264b4c7
with some modifications.
Bug: T75799
Change-Id: Ibe692fc3f3ec52a9de120b90a6d14c443e8e3720
---
M src/preprocess.js
M src/template.txt
2 files changed, 16 insertions(+), 4 deletions(-)
Approvals:
Yuvipanda: Looks good to me, approved
Legoktm: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/src/preprocess.js b/src/preprocess.js
index d7904e9..1cf6cf1 100644
--- a/src/preprocess.js
+++ b/src/preprocess.js
@@ -24,6 +24,13 @@
}
}
+function extractTaskNumber(commitMsg) {
+ var match = /^Bug:\s*(T\d+)\s*$/m.exec(commitMsg);
+ if (match !== null && match[1]) {
+ return match[1];
+ }
+}
+
exports['patchset-created'] = function(message) {
var ret = {
type: 'PS' + message.patchSet.number,
@@ -32,7 +39,8 @@
repo: formatRepo(message.change.project),
branch: filterNonDefault(message.change.branch),
url: message.change.url,
- bug: extractBugNumber(message.change.commitMessage)
+ bug: extractBugNumber(message.change.commitMessage),
+ task: extractTaskNumber(message.change.commitMessage)
};
if(ret.user === 'SuchABot') {
// Special handling for SuchABot
@@ -52,7 +60,8 @@
repo: formatRepo(message.change.project),
branch: filterNonDefault(message.change.branch),
url: message.change.url,
- bug: extractBugNumber(message.change.commitMessage)
+ bug: extractBugNumber(message.change.commitMessage),
+ task: extractTaskNumber(message.change.commitMessage)
};
if(ret.user !== message.change.owner.name) {
ret.owner = message.change.owner.name;
@@ -68,7 +77,8 @@
branch: filterNonDefault(message.change.branch),
url: message.change.url,
owner: message.change.owner.name,
- bug: extractBugNumber(message.change.commitMessage)
+ bug: extractBugNumber(message.change.commitMessage),
+ task: extractTaskNumber(message.change.commitMessage)
};
var inlineCount = message.comment.match(/(?:^|\s)\((\d+)
comments?\)(?:$|\s)/),
comment = message.comment
@@ -121,7 +131,8 @@
branch: filterNonDefault(message.change.branch),
url: message.change.url,
owner: message.change.owner.name,
- bug: extractBugNumber(message.change.commitMessage)
+ bug: extractBugNumber(message.change.commitMessage),
+ task: extractTaskNumber(message.change.commitMessage)
};
};
}
diff --git a/src/template.txt b/src/template.txt
index cd4f702..be8558a 100644
--- a/src/template.txt
+++ b/src/template.txt
@@ -19,5 +19,6 @@
[{{repo}}]
{% if branch %} ({{branch}}) {% endif %}
- {{url|color('teal')}} {% if bug %}
(https://bugzilla.wikimedia.org/{{bug}}) {% endif %}
+ {% if task %} (https://phabricator.wikimedia.org/{{task}}) {% endif %}
{% if via %}(via {{via}}) {% endif %}
{% if owner %}(owner: {{ owner |color('bold.teal')}}){% endif %}
--
To view, visit https://gerrit.wikimedia.org/r/182369
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe692fc3f3ec52a9de120b90a6d14c443e8e3720
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/grrrit
Gerrit-Branch: master
Gerrit-Owner: Glaisher <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
