jenkins-bot has submitted this change and it was merged.
Change subject: Marked replaceMultiple() as deprecated
......................................................................
Marked replaceMultiple() as deprecated
MagicWord::replaceMultiple() is completely unused in both core and
all extensions on gerrit, so it is being marked as deprecated.
Change-Id: I6289a36351a2cbc47a0cad237cc985e5c3136773
---
M includes/MagicWord.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Umherirrender: Looks good to me, approved
Florianschmidtwelzow: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/MagicWord.php b/includes/MagicWord.php
index 4b24a00..6418b9f 100644
--- a/includes/MagicWord.php
+++ b/includes/MagicWord.php
@@ -655,7 +655,7 @@
* This method uses the php feature to do several replacements at the
same time,
* thereby gaining some efficiency. The result is placed in the out
variable
* $result. The return value is true if something was replaced.
- * @todo Should this be static? It doesn't seem to be used at all
+ * @deprecated since 1.25, unused
*
* @param array $magicarr
* @param string $subject
@@ -664,6 +664,7 @@
* @return bool
*/
function replaceMultiple( $magicarr, $subject, &$result ) {
+ wfDeprecated( __METHOD__, '1.25' );
$search = array();
$replace = array();
foreach ( $magicarr as $id => $replacement ) {
--
To view, visit https://gerrit.wikimedia.org/r/181950
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6289a36351a2cbc47a0cad237cc985e5c3136773
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: McIntireEvan <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: McIntireEvan <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
