Deskana has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/183306

Change subject: Add "?source=app" to the end of all share a fact URLs per 
Analytics.
......................................................................

Add "?source=app" to the end of all share a fact URLs per Analytics.

Our EventLogging infrastructure captures the generation and sharing of facts,
but Analytics would like the ability to track how much the links are clicked,
and the best way to do that is to add a URL parameter tracking the source.
This patch adds such a parameter, conforming to the spec given to me by the
Analytics team.

Change-Id: Ie43d02653c00f40c4e1a95bcd7b05ac32f33da56
---
M wikipedia/src/main/java/org/wikipedia/page/snippet/SnippetShareAdapter.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/06/183306/1

diff --git 
a/wikipedia/src/main/java/org/wikipedia/page/snippet/SnippetShareAdapter.java 
b/wikipedia/src/main/java/org/wikipedia/page/snippet/SnippetShareAdapter.java
index 4b81852..22e9ec2 100644
--- 
a/wikipedia/src/main/java/org/wikipedia/page/snippet/SnippetShareAdapter.java
+++ 
b/wikipedia/src/main/java/org/wikipedia/page/snippet/SnippetShareAdapter.java
@@ -135,7 +135,7 @@
         PageTitle title = curPageFragment.getTitle();
         String introText = activity.getString(R.string.snippet_share_intro,
                 title.getDisplayText(),
-                title.getCanonicalUri());
+                title.getCanonicalUri() + "?source=app");
         Bitmap resultBitmap = SnippetImage.createImage(activity,
                 curPageFragment.getLeadImageBitmap(),
                 curPageFragment.getImageBaseYOffset(),

-- 
To view, visit https://gerrit.wikimedia.org/r/183306
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie43d02653c00f40c4e1a95bcd7b05ac32f33da56
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to