jenkins-bot has submitted this change and it was merged.
Change subject: Regression: MobileUI follow up
......................................................................
Regression: MobileUI follow up
Login form button not styled as constructive
Correct this.
Also apply to mobile options page.
Follow up to Ia50b5d0e8eb2daa3725e8dedcb5ff8aa618fb0f9
Change-Id: Ife383d5bdb2633c5e11d77c044ee26d5285a9a8b
---
M includes/skins/UserAccountCreateMobileTemplate.php
M includes/specials/SpecialMobileOptions.php
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Robmoen: Looks good to me, approved
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/skins/UserAccountCreateMobileTemplate.php
b/includes/skins/UserAccountCreateMobileTemplate.php
index 4f0f6ac..0ab98e3 100644
--- a/includes/skins/UserAccountCreateMobileTemplate.php
+++ b/includes/skins/UserAccountCreateMobileTemplate.php
@@ -76,7 +76,7 @@
wfMessage(
'mobile-frontend-account-create-submit' )->text(),
'submit',
array( 'id' => 'wpCreateaccount',
- 'class' => MobileUI::buttonClass(
'mw-ui-constructive' ),
+ 'class' => MobileUI::buttonClass(
'constructive' ),
'tabindex' => '6'
)
) .
diff --git a/includes/specials/SpecialMobileOptions.php
b/includes/specials/SpecialMobileOptions.php
index 61628b2..42af520 100644
--- a/includes/specials/SpecialMobileOptions.php
+++ b/includes/specials/SpecialMobileOptions.php
@@ -155,8 +155,9 @@
Html::closeElement( 'div' );
}
}
+ $className = MobileUI::buttonClass( 'constructive' );
$html .= <<<HTML
- <input type="submit" class="mw-ui-constructive mw-ui-button"
id="mw-mf-settings-save" value="{$saveSettings}">
+ <input type="submit" class="{$className}"
id="mw-mf-settings-save" value="{$saveSettings}">
$token
$returnto
</form>
--
To view, visit https://gerrit.wikimedia.org/r/183395
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife383d5bdb2633c5e11d77c044ee26d5285a9a8b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: Robmoen <rm...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
