Mhurd has submitted this change and it was merged.
Change subject: Fix for selecting 'recent' items not in current day
......................................................................
Fix for selecting 'recent' items not in current day
Was using the wrong index offset: had to pull from the split section array,
not the raw list of all entries.
Change-Id: Ibd9e94e470d9c488d7e30627706e10a8df1ce761
---
M wikipedia/View Controllers/History/HistoryViewController.m
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Mhurd: Verified; Looks good to me, approved
diff --git a/wikipedia/View Controllers/History/HistoryViewController.m
b/wikipedia/View Controllers/History/HistoryViewController.m
index 176f935..4719e31 100644
--- a/wikipedia/View Controllers/History/HistoryViewController.m
+++ b/wikipedia/View Controllers/History/HistoryViewController.m
@@ -373,13 +373,10 @@
}
- (void)tableView:(UITableView *)tableView
didSelectRowAtIndexPath:(NSIndexPath *)indexPath {
- NSString *selectedCell = nil;
NSDictionary *dict = self.historyDataArray[indexPath.section];
NSArray *array = dict[@"data"];
- selectedCell = array[indexPath.row];
+ MWKHistoryEntry *historyEntry = array[indexPath.row];
- MWKHistoryEntry *historyEntry = [[SessionSingleton
sharedInstance].userDataStore.historyList entryAtIndex:indexPath.row];
-
[NAV loadArticleWithTitle: historyEntry.title
animated: YES
discoveryMethod: MWK_DISCOVERY_METHOD_SEARCH
--
To view, visit https://gerrit.wikimedia.org/r/183616
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd9e94e470d9c488d7e30627706e10a8df1ce761
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Mhurd <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
