Nemo bis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/183780

Change subject: Don't discourage usage of Html::element()
......................................................................

Don't discourage usage of Html::element()

Old advice from 2009 (7aa4a8f9), not quite useful nowadays. The preceding
sentence already says that in absence of attributes the function may not
do much.

Change-Id: I4d276d6f42394fc09662ddfd7e1ffd13fb197bf6
---
M includes/Html.php
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/80/183780/1

diff --git a/includes/Html.php b/includes/Html.php
index e033746..93a1a04 100644
--- a/includes/Html.php
+++ b/includes/Html.php
@@ -198,8 +198,7 @@
        /**
         * Returns an HTML element in a string.  The major advantage here over
         * manually typing out the HTML is that it will escape all attribute
-        * values.  If you're hardcoding all the attributes, or there are none, 
you
-        * should probably just type out the html element yourself.
+        * values.
         *
         * This is quite similar to Xml::tags(), but it implements some useful
         * HTML-specific logic.  For instance, there is no $allowShortTag

-- 
To view, visit https://gerrit.wikimedia.org/r/183780
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d276d6f42394fc09662ddfd7e1ffd13fb197bf6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Nemo bis <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to