Amire80 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/183845
Change subject: Remove repeated code in translation link creation
......................................................................
Remove repeated code in translation link creation
Change-Id: Ie55be8a113a6190b808d81b39c25d00a7779fdbb
---
M modules/dashboard/ext.cx.translationlist.js
1 file changed, 22 insertions(+), 20 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/45/183845/1
diff --git a/modules/dashboard/ext.cx.translationlist.js
b/modules/dashboard/ext.cx.translationlist.js
index 86a0f78..23a735f 100644
--- a/modules/dashboard/ext.cx.translationlist.js
+++ b/modules/dashboard/ext.cx.translationlist.js
@@ -133,8 +133,10 @@
* @param {Object[]} translations
*/
CXTranslationList.prototype.listTranslations = function ( translations
) {
- var i, translation, $translation, $titleLanguageBlock,
$translationLink, $sourceLanguage,
- $targetLanguage, $imageBlock, $lastUpdated, $image,
$status, $progressbar,
+ var i, translation, $translation, $titleLanguageBlock,
+ $translationLink, translationLinkUrl,
+ $sourceLanguage, $targetLanguage,
+ $imageBlock, $lastUpdated, $image, $status,
$progressbar,
$actionsTrigger, $menu, $menuContainer,
$deleteTranslation;
for ( i = 0; i < translations.length; i++ ) {
@@ -159,26 +161,26 @@
this.showTitleImage( translation );
if ( translation.status === 'draft' ) {
- $translationLink = $( '<a>' )
- .addClass( 'source-title' )
- .attr( {
- href: new mw.Uri().extend( {
- from:
translation.sourceLanguage,
- to:
translation.targetLanguage,
- page:
translation.sourceTitle,
- targettitle:
translation.targetTitle,
- draft:
translation.status === 'draft' ? translation.id : undefined
- } ).toString()
- } ).text( translation.sourceTitle );
+ translationLinkUrl = new mw.Uri().extend( {
+ from: translation.sourceLanguage,
+ to: translation.targetLanguage,
+ page: translation.sourceTitle,
+ targettitle: translation.targetTitle,
+ draft: translation.status === 'draft' ?
translation.id : undefined
+ } ).toString();
}
+
if ( translation.status === 'published' ) {
- $translationLink = $( '<a>' )
- .addClass( 'source-title' )
- .attr( {
- href: translation.targetURL
- } )
- .text( translation.sourceTitle );
+ translationLinkUrl = translation.targetURL;
}
+
+ $translationLink = $( '<a>' )
+ .addClass( 'source-title' )
+ .text( translation.sourceTitle )
+ .attr( {
+ href: translationLinkUrl
+ } );
+
$sourceLanguage = $( '<div>' )
.addClass( 'source-language' )
.text( $.uls.data.getAutonym(
translation.sourceLanguage ) );
@@ -332,7 +334,7 @@
action: 'cxdelete',
from: translation.sourceLanguage,
to: translation.targetLanguage,
- sourcetitle: translation.sourceTitle,
+ sourcetitle: translation.sourceTitle
};
return new mw.Api().postWithToken( 'edit', apiParams );
--
To view, visit https://gerrit.wikimedia.org/r/183845
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie55be8a113a6190b808d81b39c25d00a7779fdbb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
