Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184011
Change subject: Fixing EventLogging classes so they don't fail schema validation
......................................................................
Fixing EventLogging classes so they don't fail schema validation
Change-Id: I1fa48de1ae36ad1dbce06d4ed1ec8d190d9a50ac
---
M javascripts/loggingSchemas/SchemaMobileWebEditing.js
M javascripts/loggingSchemas/SchemaMobileWebUploads.js
M javascripts/loggingSchemas/SchemaMobileWebWikiGrok.js
3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/11/184011/1
diff --git a/javascripts/loggingSchemas/SchemaMobileWebEditing.js
b/javascripts/loggingSchemas/SchemaMobileWebEditing.js
index 4859fb2..5cb17ff 100644
--- a/javascripts/loggingSchemas/SchemaMobileWebEditing.js
+++ b/javascripts/loggingSchemas/SchemaMobileWebEditing.js
@@ -18,8 +18,8 @@
namespace: mw.config.get( 'wgNamespaceNumber' ),
isTestA: M.isTestA,
// FIXME: Introduce a SchemaWithUser class that has
username and userEditCount
- username: user.getName() || '',
- userEditCount: user.getEditCount() || 0
+ username: user.getName() || undefined,
+ userEditCount: typeof user.getEditCount() === 'number'
? user.getEditCount() : undefined
} )
} );
diff --git a/javascripts/loggingSchemas/SchemaMobileWebUploads.js
b/javascripts/loggingSchemas/SchemaMobileWebUploads.js
index 003feac..4cb3bfc 100644
--- a/javascripts/loggingSchemas/SchemaMobileWebUploads.js
+++ b/javascripts/loggingSchemas/SchemaMobileWebUploads.js
@@ -16,7 +16,7 @@
token: Schema.getSessionId(),
funnel: 'unknown',
// FIXME: Introduce a SchemaWithUser class and rethink
the data recorded that follows
- username: user.getName(),
+ username: user.getName() || undefined,
isLoggedIn: !user.isAnon(),
isEditable: mw.config.get( 'wgIsPageEditable' )
} )
diff --git a/javascripts/loggingSchemas/SchemaMobileWebWikiGrok.js
b/javascripts/loggingSchemas/SchemaMobileWebWikiGrok.js
index da35adf..c91dfb3 100644
--- a/javascripts/loggingSchemas/SchemaMobileWebWikiGrok.js
+++ b/javascripts/loggingSchemas/SchemaMobileWebWikiGrok.js
@@ -13,7 +13,7 @@
defaults: $.extend( {}, Schema.prototype.defaults, {
// FIXME: Introduce a SchemaWithUser class that has
username and userEditCount
isLoggedIn: !user.isAnon(),
- userEditCount: user.getEditCount() || 0,
+ userEditCount: typeof user.getEditCount() === 'number'
? user.getEditCount() : undefined,
pageId: mw.config.get( 'wgArticleId' )
} )
} );
--
To view, visit https://gerrit.wikimedia.org/r/184011
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fa48de1ae36ad1dbce06d4ed1ec8d190d9a50ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
