Yuvipanda has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/184142

Change subject: Fix refactoring snafu
......................................................................

Fix refactoring snafu

Change-Id: I266e8d4ff24c1c538704f056cf9aefa7e34a0a0c
---
M auditor/reports/tables.py
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/software/labsdb-auditor 
refs/changes/42/184142/1

diff --git a/auditor/reports/tables.py b/auditor/reports/tables.py
index c5e73cd..4e65895 100644
--- a/auditor/reports/tables.py
+++ b/auditor/reports/tables.py
@@ -18,7 +18,7 @@
 
 
 def _get_extra_tables(model, conn, dbs):
-    extra_tables = {}  # K:V :: tablename::list<dbname>
+    extra_tables_dbs = {}  # K:V :: tablename::list<dbname>
     for db in dbs:
         logging.debug('Finding extra tables on %s', db)
         try:
@@ -33,11 +33,11 @@
                 raise
         if extra_tables:
             for tablename in extra_tables:
-                if tablename in extra_tables:
-                    extra_tables[tablename].append(db)
+                if tablename in extra_tables_dbs:
+                    extra_tables_dbs[tablename].append(db)
                 else:
-                    extra_tables[tablename] = [db]
-    return extra_tables
+                    extra_tables_dbs[tablename] = [db]
+    return extra_tables_dbs
 
 
 def extra_tables_report(config, model, conn):

-- 
To view, visit https://gerrit.wikimedia.org/r/184142
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I266e8d4ff24c1c538704f056cf9aefa7e34a0a0c
Gerrit-PatchSet: 1
Gerrit-Project: operations/software/labsdb-auditor
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to