Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/184219

Change subject: Update HTMLForm usage for I086a84f1 in MediaWiki
......................................................................

Update HTMLForm usage for I086a84f1 in MediaWiki

Change-Id: I086a84f1c8cc6a16710709b7806c7f5f96462b32
---
M includes/specials/SpecialGlobalRenameQueue.php
M includes/specials/SpecialGlobalRenameRequest.php
2 files changed, 8 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/19/184219/1

diff --git a/includes/specials/SpecialGlobalRenameQueue.php 
b/includes/specials/SpecialGlobalRenameQueue.php
index 6f57c8c..5b12503 100644
--- a/includes/specials/SpecialGlobalRenameQueue.php
+++ b/includes/specials/SpecialGlobalRenameQueue.php
@@ -227,7 +227,7 @@
                        'globalrenamequeue-request-title', array( 
$req->getName() )
                );
 
-               $form = new HTMLForm(
+               $form = HTMLForm::factory( 'vform',
                        array(
                                'rid' => array(
                                        'default' => $req->getId(),
@@ -292,8 +292,6 @@
                );
 
                $form->setId( 'mw-globalrenamequeue-request' );
-               $form->setDisplayFormat( 'vform' );
-               $form->setWrapperLegend( false );
 
                if ( $req->userIsGlobal() ) {
                        $globalUser = new CentralAuthUser( $req->getName() );
diff --git a/includes/specials/SpecialGlobalRenameRequest.php 
b/includes/specials/SpecialGlobalRenameRequest.php
index b9196fe..72c1c46 100644
--- a/includes/specials/SpecialGlobalRenameRequest.php
+++ b/includes/specials/SpecialGlobalRenameRequest.php
@@ -116,14 +116,19 @@
        * @param HTMLForm $form
        */
        protected function alterForm( HTMLForm $form ) {
-               $form->setDisplayFormat( 'vform' );
-               $form->setWrapperLegend( false );
                $form->setSubmitTextMsg( 'globalrenamerequest-submit-text' );
        }
 
        /**
         * @return string
         */
+       protected function getDisplayFormat() {
+               return 'vform';
+       }
+
+       /**
+        * @return string
+        */
        protected function preText() {
                $msg = $this->msg( 'globalrenamerequest-pretext' )->parse();
                if ( !$this->isGlobalUser() ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/184219
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I086a84f1c8cc6a16710709b7806c7f5f96462b32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to