jenkins-bot has submitted this change and it was merged.
Change subject: ve.dm.{MWTransclusionModel,MWTemplateModel}: Remove unused
parameters
......................................................................
ve.dm.{MWTransclusionModel,MWTemplateModel}: Remove unused parameters
The 'origin' parameter to the constructors has been removed in 51e096d6.
Change-Id: I885f75c381cea013d32d408c7b26de0fa00629c2
---
M modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
M modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
b/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
index ec8a0da..773ed36 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
@@ -61,11 +61,11 @@
*/
ve.dm.MWTemplateModel.newFromData = function ( transclusion, data ) {
var key,
- template = new ve.dm.MWTemplateModel( transclusion,
data.target, 'data' );
+ template = new ve.dm.MWTemplateModel( transclusion, data.target
);
for ( key in data.params ) {
template.addParameter(
- new ve.dm.MWParameterModel( template, key,
data.params[key].wt, 'data' )
+ new ve.dm.MWParameterModel( template, key,
data.params[key].wt )
);
}
@@ -95,7 +95,7 @@
}
if ( title !== null ) {
href = title.getPrefixedText();
- return new ve.dm.MWTemplateModel( transclusion, { href: href,
wt: name }, 'user' );
+ return new ve.dm.MWTemplateModel( transclusion, { href: href,
wt: name } );
}
return null;
diff --git a/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
b/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
index d4e538d..4dbe9bb 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js
@@ -115,7 +115,7 @@
deferred = $.Deferred();
promises.push( deferred.promise() );
this.queue.push( {
- add: new
ve.dm.MWTransclusionContentModel( this, part, 'data' ),
+ add: new
ve.dm.MWTransclusionContentModel( this, part ),
deferred: deferred
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/184231
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I885f75c381cea013d32d408c7b26de0fa00629c2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz DziewoĆski <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits