EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184489
Change subject: Bug: Comparing array against maybe array
......................................................................
Bug: Comparing array against maybe array
The provided sort value can either be an array or a single string
if there is only one field to sort by. This is used, for example,
in BoardHistoryQuery. There shouldn't be any directly visible changes
due to this patch, board history will start using the index
but the user experience should be the same as we were falling back
to direct db query previously where this is incorrect.
Change-Id: I3b1ec3d29035f780e77a6ae42b01492f948308aa
---
M includes/Data/Index/TopKIndex.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/89/184489/1
diff --git a/includes/Data/Index/TopKIndex.php
b/includes/Data/Index/TopKIndex.php
index a7c4d14..9bc3c50 100644
--- a/includes/Data/Index/TopKIndex.php
+++ b/includes/Data/Index/TopKIndex.php
@@ -47,7 +47,7 @@
return false;
}
if ( isset( $options['sort'], $options['order'] ) ) {
- return $options['sort'] === $this->options['sort']
+ return ObjectManager::makeArray( $options['sort'] ) ===
$this->options['sort']
&& strtoupper( $options['order'] ) ===
$this->options['order'];
}
return true;
--
To view, visit https://gerrit.wikimedia.org/r/184489
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b1ec3d29035f780e77a6ae42b01492f948308aa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
